fix(get-next-bump): fix to permit usage of --get-next option even when update_changelog_on_bump is set to true #1301
Conversation
…en update_changelog_on_bump is set to true
Lowaiz
force-pushed
the
fix/get-next-config
branch
from
d563504 to
e5d6797
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1301 +/- ##
==========================================
+ Coverage 97.33% 97.55% +0.21%
==========================================
Files 42 55 +13
Lines 2104 2613 +509
==========================================
+ Hits 2048 2549 +501
- Misses 56 64 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lowaiz
changed the title
|
@Lee-W @noirbizarre @woile |
Will take a look these days. Thanks for reminding me! |
Description
With the configuration options
update_changelog_on_bumpset toTrue, the commandcz bump --get-nextcrashed, due to the mutual exclusive options--get-nextand--changelog/--changelog-to-stdout.Changing this behavior to still throw a conflict when using both CLI options, but let
--get-nexttake the precedence overupdate_changelog_on_bumpconfiguration.Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Now the configuration options
update_changelog_on_bumpcan be set to whatever you want when using thecz bump --get-nextcommand.Steps to Test This Pull Request
update_changelog_on_bumpflag set to true.cz bump --get-nextAdditional context